MRCollective / ChameleonForms

Shape-shifting your forms experience in ASP.NET Core MVC
MIT License
254 stars 56 forks source link

Checkboxes are not displaying correctly since Bootstrap v3.2 #103

Closed michael-wolfenden closed 9 years ago

michael-wolfenden commented 9 years ago

ChameleonForms is generating the following output for checkboxes:

<div class="checkbox">
    <input id="TermsAndConditions" name="TermsAndConditions" type="checkbox" value="true"> 
    <label for="TermsAndConditions">Terms and conditions</label>
    <em class="required" title="Required">∗</em>
</div>

However according to the Bootstrap documentation the markup should be:

<div class="checkbox">
    <label>
        <input id="TermsAndConditions" name="TermsAndConditions" type="checkbox" value="true" /> 
        Terms and conditions
    </label>
    <em class="required" title="Required">&lowast;</em>
</div>

The current markup causes the checkbox to be out of alignment as seen in this JSBin

Happy to submit a pull request to fix, however wasn't sure how you guys wanted to handle backwards compatibility for earlier versions of boostrap (although I did a quick check and the new html seems to display correctly back to v3.0.0)

robdmoore commented 9 years ago

Nice pick up.

Yep - send through a PR. Maybe update the NuSpec to indicate a later version of bootstrap too.

On 16 Nov 2014, at 7:01 pm, Michael Wolfenden notifications@github.com wrote:

ChameleonForms is generating the following output for checkboxes:

However according to the Bootstrap documentation the markup should be:

The current markup causes the checkbox to be out of alignment as seen in this JSBin

Happy to submit a pull request to fix, however wasn't sure how you guys wanted to handle backwards compatibility for earlier versions of boostrap (although I did a quick check and the new html seems to display correctly back to v3.0.0)

— Reply to this email directly or view it on GitHub.