search

MRCollective / ChameleonForms

Shape-shifting your forms experience in ASP.NET Core MVC
MIT License
254 stars 56 forks source link

Partial for implementation 2 #110

Closed zabulus closed 9 years ago

zabulus commented 9 years ago

According to suggestions from #107 I've added implementations for: @f.PartialSectionFor(x => x.Whatever, "PartialViewModel"); @this.ChamleonForm() @this.IsChameleonSection() @this.IsChameleonForm()

Working on IEnumerable (https://github.com/MRCollective/ChameleonForms/pull/104#issuecomment-64074719) is stuck for now. Will try it again later, and publish as additional fix.

robdmoore commented 9 years ago

Hi @zabulus,

Thanks so much for the contribution!

There is a fair amount of noise in this PR from the change to remove the TTemplate parameter. Is there any chance that can be a separate pull request that we can pull in first to make this PR easier to understand?

zabulus commented 9 years ago

Ok, I'll split the implementation into two separate PRs

robdmoore commented 9 years ago

Thanks!

On 3 Jan 2015, at 6:12 pm, zabulus notifications@github.com wrote:

Ok, I'll split the implementation into two separate PRs

— Reply to this email directly or view it on GitHub.