search

MRCollective / ChameleonForms

Shape-shifting your forms experience in ASP.NET Core MVC
MIT License
254 stars 56 forks source link

ReadOnlyConfiguration class is redundant #119

Closed zabulus closed 9 years ago

zabulus commented 9 years ago

I think that ReadOnlyConfiguration class is redundant because it is just forwards all calls to IFieldConfiguration. I think we can delete it without problems, and just make IReadonlyFieldConfiguration a part of IFieldConfiguration. BTW as I see IReadonlyFieldConfiguration is used just for internal purposes, maybe it should be hidden as private? What do you think?

robdmoore commented 9 years ago

If you can do this without breaking the public API and without removing IReadonlyFieldConfiguration (it's important) then feel free to submit a PR - would gladly merge that. It's a bit of a pain we have to keep the other class up to date!

zabulus commented 9 years ago

Closing this