search

MRCollective / ChameleonForms

Shape-shifting your forms experience in ASP.NET Core MVC
MIT License
254 stars 56 forks source link

Fix Bootstrap checkbox display issue #129

Closed jtheisen closed 8 years ago

jtheisen commented 9 years ago

I didn't manage to rebase properly, so I created a new pull request.

This is another attempt at fixing #103.

I put the new option in and the name and the defaults are as you suggested.

robdmoore commented 9 years ago

Looking good. 2 more things I think are needed.

Change the version number of the bootstrap dependency in ChameleonForms.TwitterBootstrap3.nuspec to match the version you've updated to.

Add in a test for each of the two instances where there setting the new field configuration changes the HTML.

jtheisen commented 9 years ago

That should be all you mentioned.

I'm not sure if the tighter bootstrap version requirement is necessary: It's not that ChameleonForms.Twitterbootstrap requires the new version. The new version just requires the fix.

jtheisen commented 9 years ago

Can I get an update on this?

robdmoore commented 8 years ago

Sorry for the delay.

Thanks for the contribution!

jtheisen commented 8 years ago

No problem - do you have any rough idea when there will be a release, and especially when the NuGet package will be updated?

robdmoore commented 8 years ago

Hi @jtheisen.

It will be released once #132 is merged and we publish v2.0.

Sorry for the delay. We wouldn't normally wait so long to release, but there were a few breaking changes we wanted to bunch up.

cc @MattDavies

jtheisen commented 8 years ago

No problem, thank you for your efforts.