MRCollective / ChameleonForms

Shape-shifting your forms experience in ASP.NET Core MVC
MIT License
254 stars 56 forks source link

Fixes for tests in the German culture. #130

Closed jtheisen closed 9 years ago

jtheisen commented 9 years ago

I already mentioned that the tests don't run properly because of culture issues.

I fixed some of them in this pull requests.

The most important one is that I specify the invariant culture for all all ChameleonForms.Tests tests. That fixes all the broken tests of that kind for me.

I also fixed some issues I have with the acceptance tests, but not all.

One problem is that it's not easy to find a DateTime format string that survives a serialization-parsing-roundtrip in all cultures. The "tt" specifier doesn't exist in the German culture (and neither does it in the invariant culture), so I changed the example format to a 24h clock format.

There is a remaining issue unobtrusive javascript validation and cultures (which I don't use in my own apps). The javascript on the example forms don't validate because it can't parse decimals (as the dot is a comma in German numbers). Maybe I find a fix for this later, but right now unobtrusive validation isn't a priority for me.

robdmoore commented 9 years ago

Thanks