search

MRCollective / ChameleonForms

Shape-shifting your forms experience in ASP.NET Core MVC
MIT License
254 stars 56 forks source link

#56 Makes radio list ids consistent for child view models #57

Closed becdetat closed 11 years ago

robdmoore commented 11 years ago

What line endings did you check the approval file in as? Is the .approved file in this diff?

If you can't work it out I can RDp into the Ci server to see what's up.

robdmoore commented 11 years ago

Also, http://blog.pravesh.me/files/2012/08/worksonmymachine.jpg :p

robdmoore commented 11 years ago

Hmm just RDP'd and checked it out - it's definitely a line endings issue. The .approved file is LF for some reason. This makes sense based on my new understanding of how git stores files controlled by .gitattributes, however, I'm confused as to why the other approval tests files haven't had the same issue...

becdetat commented 11 years ago

Yeah looks like I've got autocrlf on. FML.

Also nobody likes a smartarse.

Oh who am I kidding, I can't stay angry at you. :cake:

robdmoore commented 11 years ago

Oh dear god, just realised we aren't using .gitattributes. This explains everything.

Change your autocrlf setting to off and commit the file as crlf.

I'll need to get .gitattributes sorted. Will add an issue.