search

MRCollective / ChameleonForms

Shape-shifting your forms experience in ASP.NET Core MVC
MIT License
254 stars 56 forks source link

Issue #79 IFieldConfiguration.AddFieldContainerClass #87

Closed cuzzlor closed 10 years ago

cuzzlor commented 10 years ago

Hi MRCollectives,

I've added in the AddFieldContainerClass method as suggested for this #upforgrabs issue. Please feel free to suggest a different approach if you can think a more elegant one. Hopefully I have set up the tests correctly and the implementation is sound. Whatever the case it was a great learning experience for me!

Note: I committed the ChameleonForms.Tests package config and project file changes from adding the NUnit Test Adapter nuget package to run the tests locally. I should not have committed those but it's probably easy for you to ignore these changes during the merge right?

Cheers!

robdmoore commented 10 years ago

Awesome - thanks for this contribution. I'll take a look over the next few days :)

robdmoore commented 10 years ago

Can you remove the nunit stuff? If you do that then I'm happy to merge this in :)

cuzzlor commented 10 years ago

Done, hope that's all OK? Thanks for the time and advice :)

robdmoore commented 10 years ago

Yep looks good - thanks mate :)

I'll merge this, push out a release using TeamCity and update the wiki.

robdmoore commented 10 years ago

1.1.0 has been pushed out to NuGet, created on GitHub and the documentation updated to include the new feature. Thanks again.

cuzzlor commented 10 years ago

Thanks Rob I'm honoured to be able to learn and make a contribution. Cheers for your work!!

On 10 May 2014, at 5:33 pm, Robert Moore notifications@github.com wrote:

1.1.0 has been pushed out to NuGet, created on GitHub and the documentation updated to include the new feature. Thanks again.

— Reply to this email directly or view it on GitHub.