Make MRPT_EXCEPTIONS_WITH_CALL_STACK public

MRPT / mrpt

:zap: The Mobile Robot Programming Toolkit (MRPT)

https://docs.mrpt.org/reference/latest/

BSD 3-Clause "New" or "Revised" License

1.93k stars 630 forks source link

Make MRPT_EXCEPTIONS_WITH_CALL_STACK public #1146

Closed jolting closed 3 years ago

jolting commented 3 years ago

MRPT_EXCEPTIONS_WITH_CALL_STACK was not public, so it wasn't being defined in unit tests or apps.

Any define used in a public header file should be a PUBLIC define.

I acknowledge to have:

Read the CONTRIBUTING page
Updated doc/doxygen-pages/changeLog_doc.h to describe these changes (if applicable)
Updated AUTHORS (if applicable)

(Notify: @MRPT/owners )

jolting commented 3 years ago

Just realized this is wrong.

jlblancoc commented 3 years ago

hehe, no problem! It's only used in one .cpp file, so it should remain private...

Also, I don't want to "polute" the list of arguments of downstream projects, so as a general rule we should prefer config.h files to cmake PUBLIC definitions.