Closed christian-rauch closed 2 years ago
Thanks for raising the issue, @christian-rauch !
- the documentation is confusing about the stored unit (metre, millimetre)
It's been fixed in 037863b91598150c482759d2ee2be721f27560b5, within hours it will be reflected on the online docs. Let me know if you still see inconsistencies... maintaining the docs is a huge and endless effort! ;-)
- changing the unit to millimetre silently breaks many algorithms that read that data and assume it is stored in metres as before
Sorry for that, here we should have changed the name to break builds after the change, you are right. The change to uint16_t was strongly motivated, though:
In
1.5.8
, theCObservation::rangeImage
had typeCMatrix
with units metre ("a matrix of floats with the range data as captured by the camera (in meters)"). In 2.x, this changed to typeCMatrix_u16
, suggesting that distances are stores as 16bit millimetre, but the documentation still says "a matrix of floats with the range data as captured by the camera (in meters)".There are two issues here: