search

MRPT / mrpt

:zap: The Mobile Robot Programming Toolkit (MRPT)
https://docs.mrpt.org/reference/latest/
BSD 3-Clause "New" or "Revised" License
1.94k stars 628 forks source link

Feature/refactor debian #1192

Closed jlblancoc closed 2 years ago

jlblancoc commented 2 years ago

Refactoring of release scripts and removal of debian/* from this repo, since we'll move to gbp using this salsa repo.

cc: @jspricke Please, take a look at the updated instructions in doc/source/make_a_mrpt_release.rst, and feel free of proposing any further changes.

Closes #1189

jlblancoc commented 2 years ago

In particular, please check for my questions/doubts in lines starting with "JL:" Thanks.

jlblancoc commented 2 years ago

@jspricke Please, if possible take another look at this PR so it can be merged:

Thanks!

jlblancoc commented 2 years ago

This looks already really good :). The only thing I noticed are that the cmake files are not installed into the correct directory. Some are in lib/<multi-arch>/mrpt_* and the rest in share/mrpt_*. The correct directory would be lib/<mutli-arch>/cmake/mrpt_*. Can you fix that?

Done! I think the /share/... target was also supported in the early days of cmake, but lib/cmake/foo/ is the most common :+1:

Over all I would recommend to run shellcheck on this.

wow, what a discovery! thanks.

jspricke commented 2 years ago

This looks already really good :). The only thing I noticed are that the cmake files are not installed into the correct directory. Some are in lib/<multi-arch>/mrpt_* and the rest in share/mrpt_*. The correct directory would be lib/<mutli-arch>/cmake/mrpt_*. Can you fix that?

Done! I think the /share/... target was also supported in the early days of cmake, but lib/cmake/foo/ is the most common +1

Both are supported, share/ is for architecture independent files, whereas those I checked are not (they contain the multi-arch dir).