search

MRPT / mrpt

:zap: The Mobile Robot Programming Toolkit (MRPT)
https://docs.mrpt.org/reference/latest/
BSD 3-Clause "New" or "Revised" License
1.94k stars 628 forks source link

pymrpt missing in ros-noetic-mrpt2, 2.4.10 release #1247

Closed ihadzic closed 2 years ago

ihadzic commented 2 years ago

Before release 2.4.9, pymrpt.so was at the wrong location. This was reported in #1232 and the patch that was supposed to fix it, 5486914e5635da8839f2a558f72ccf533ef76750, was merged into master and released in 2.4.9. Today I updated from ROS distro and got 2.4.10, but pymrpt.so is completely missing.

I suspect that either the ROS packaging process didn't pick up the .so correctly or 5486914e5635da8839f2a558f72ccf533ef76750 didn't work.

ihadzic commented 2 years ago

For reference here is the .so in the older version of mrpt2 (albeit at incorrect location):

$ dpkg -l ros-noetic-mrpt2
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name             Version                      Architecture Description
+++-================-============================-============-===================================================
ii  ros-noetic-mrpt2 2.4.4-1focal.20220514.015241 amd64        Mobile Robot Programming Toolkit (MRPT) version 2.x
$ dpkg -L ros-noetic-mrpt2 | grep pymrpt
/opt/ros/noetic/lib/x86_64-linux-gnu/python3.8/dist-packages/pymrpt.so
ihadzic commented 2 years ago

and here it is missing in 2.4.10:

$ dpkg -l ros-noetic-mrpt2
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name             Version                       Architecture Description
+++-================-=============================-============-===================================================
ii  ros-noetic-mrpt2 2.4.10-1focal.20220630.135834 amd64        Mobile Robot Programming Toolkit (MRPT) version 2.x
$ dpkg -L ros-noetic-mrpt2 | grep pymrpt

(nothing comes up after piped to grep)

jlblancoc commented 2 years ago

Thanks for reporting! It seems it was actually caused by a misdetection of the boost python3 module. The current latest build from the develop branch on ROS1 build farm for Noetic still shows no pymrpt module.

Hopefully, it should be fixed with c36deef46e41df0db3158bc046d1ddcc15e79d9c , let's keep an eye on ROS' Jenkins.

This line:

18:00:38 --  Python3 bindings (pymrpt)   :  No [Version: 3.8]

should say "Yes"...

jlblancoc commented 2 years ago

Ok, I have confirmed the commit above fixes it. Next release (v2.5.0) should come with the pymrpt.so in its place again!