search

MRU-COMP1701-dev / fopp-functions-first

Foundations of Python Programming: Functions First
GNU Free Documentation License v1.3
0 stars 3 forks source link

Ch1 edits #6

Closed echalmers closed 1 year ago

echalmers commented 1 year ago

Just necessary corrections and wording fixes for chapter 1. I suspect there will be more edits needed to later chapters, but let me know if you were hoping for a higher level of editing & revision. Some of the presentation isn't how I would have done it, but it's a free textbook right? :)

PJPerri commented 1 year ago

EricWe cool but - I thought I had the folders from Functions on (meaning General Info was mine to do. PJ PerriSenior InstructorMount Royal UniversityHe/His/HimOn Jun 14, 2023, at 4:18 PM, echalmers @.***> wrote: @echalmers requested your review on: #6 Ch1 edits.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

PJPerri commented 1 year ago

EricWe cool but - I thought I had the folders from Functions on (meaning General Info was mine to do. )PJ PerriSenior InstructorMount Royal UniversityHe/His/HimOn Jun 14, 2023, at 4:18 PM, echalmers @.***> wrote: @echalmers requested your review on: #6 Ch1 edits.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because your review was requested.Message ID: @.***>

echalmers commented 1 year ago

Ah! Right, thanks. Somehow I started thinking I was doing the first half chronologically instead of alphabetically. Now that it's here - were you planning on doing more changes than this @PJPerri ?

PJPerri commented 1 year ago

EricTomorrow I will look and see. PJ PerriMRU Senior Lecturer, He/him/hisOki /Amba'wastitch / Danit'ada / Tans'iI send this email from the hereditary homelands of the Niitsitapi (the Blackfoot Confederacy: Siksika, Piikani, Kainai), the Îyârhe Nakoda, and Tsuut'ina Nations. Calgary is also home to the Metis Nation Region 3. We are all Treaty People. This communication is intended for the use of the recipient to which it is addressed, and may contain confidential, personal, and or privileged information. Please contact the sender immediately if you are not the intended recipient of this communication, and do not copy, distribute, or take action relying on it. Any communication received in error, or subsequent reply, should be deleted or destroyed.On Jun 14, 2023, at 4:44 PM, echalmers @.***> wrote: Ah! Right, thanks. Somehow I started thinking I was doing the first half chronologically instead of alphabetically. Now that it's here - were you planning on doing more changes than this @PJPerri ?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

PJPerri commented 1 year ago

Eric (and Charlotte)

I suspect I have been engaging in way too too much authoring.¯_(ツ)_/¯

I actually did lots on GenInfo Ch1 myself. I looked at your changes and incorporated them into what I have done.

PJ

On Wed, Jun 14, 2023 at 4:18 PM echalmers @.***> wrote:

Just necessary corrections and wording fixes for chapter 1. I suspect there will be more edits needed to later chapters, but let me know if you were hoping for a higher level of editing & revision. Some of the presentation isn't how I would have done it, but it's a free textbook right? :)

You can view, comment on, or merge this pull request online at:

https://github.com/MRU-COMP1701-dev/fopp-pretext/pull/6 Commit Summary

File Changes

(3 files https://github.com/MRU-COMP1701-dev/fopp-pretext/pull/6/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/MRU-COMP1701-dev/fopp-pretext/pull/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWSSALCS7VLI2EFLEOIBNA3XLI2EVANCNFSM6AAAAAAZG7VCEA . You are receiving this because your review was requested.Message ID: @.***>