search

MRepoApp / MRepo

A modules manager for Magisk, KernelSU and APatch
GNU General Public License v3.0
1k stars 44 forks source link

[FR] Label for "Reboot" button #191

Closed MisterFloppy closed 5 months ago

MisterFloppy commented 5 months ago

Checklist

Enhancement propose

When a module has been updated through MRepo and a reboot is required, there is only an unlabeled button popping up. I would like to intercept this moment with Tasker and its plugin AutoInput, but I can't because this app needs some text to react to.

Solution

Could you please add an useful label named "Reboot" or so to this button?

Additional info

No response

SanmerDev commented 5 months ago

I don't understand your needs, but if you want to know whether any modules have been updated, you can scan whether there is an update file under /data/adb/modules/<ID>

MisterFloppy commented 5 months ago

Screenshot_2024-03-29-14-33-35-585_com sanmer mrepo Screenshot_2024-03-29-14-41-28-105_com sanmer mrepo

After I have clicked the "Update" button (first screenshot), the update process begins and finally looks like the second screenshot. Then a little button appears at the bottom right position indicating a reboot is required.

I don't want to reboot straight away, but let the app "Tasker" automatically recognize that the update process has ended. However, Tasker must "see" some text on the screen it can react to, so it would be great if you could add something like "Reboot" to the reboot button.

SanmerDev commented 5 months ago

You can also use subtitle (shows the status of the process) on the TopBar. But I don't understand why you want Tasker to decide whether to reboot.

MisterFloppy commented 5 months ago

What do you mean with "subtitle"? Is it an option in MRepo? Or an Android setting? Or a Magisk module? Sorry, I'm absolutely clueless...

MisterFloppy commented 5 months ago

This is how it looks when you install a module from zip archive through Magisk. Tasker can detect the completed installation by recognizing the word "Neustart". This way it can programatically take some precautionary measures before the actual reboot happens.

Screenshot_2024-03-29-22-52-46-025_com topjohnwu magisk

MisterFloppy commented 5 months ago

Ahhhh... I must have been blind :-) I didn't see that the text right after the completed installation on the top has changed to "Fertig!".

Okay, thank you - case closed.