MRsources / MRzero-Core

GNU Affero General Public License v3.0
27 stars 6 forks source link

Custom Voxel Phantom - has no size? #36

Closed mzaiss closed 5 months ago

mzaiss commented 8 months ago

while a voxel size is possible, no "size" in SI is possible for the Custom Voxel Phantom Or did I miss something?

needed for exact representation of educational 1D / 2D encoding.

J-Endres commented 6 months ago

The custom voxel phantom itself has no size since the position of every single voxel is set manually: For example, to create a phantom with a size of 20 cm you would need to assure all voxel positions are within -0.1 to 0.1 (or 0.0 to 0.2 or any other range, there is no need to force any arbitrary convention here)

mzaiss commented 6 months ago

yes, but it needs to added in the docu that the position values are now si units (m) as well

J-Endres @.***> schrieb am Di., 9. Apr. 2024, 14:57:

The custom voxel phantom itself has no size since the position of every single voxel is set manually: For example, to create a phantom with a size of 20 cm you would need to assure all voxel positions are within -0.1 to 0.1 (or 0.0 to 0.2 or any other range, there is no need to force any arbitrary convention here)

— Reply to this email directly, view it on GitHub https://github.com/MRsources/MRzero-Core/issues/36#issuecomment-2045121948, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB7RKGQIOGQEE7GQQDJYOVLY4PQTVAVCNFSM6AAAAABDYV5XHSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBVGEZDCOJUHA . You are receiving this because you authored the thread.Message ID: @.***>

J-Endres commented 5 months ago

Fixed by 1617420dd645f2e9bfb0d6e5dee8f7cc68ff0bf0