search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
293 stars 180 forks source link

conflicting(or incomplete?) copyright statement in cmd/fod2dec.cpp #1454

Open yarikoptic opened 6 years ago

yarikoptic commented 6 years ago 
$> grep Copyright cmd/fod2dec.cpp
 * Copyright (c) 2008-2018 the MRtrix3 contributors.
    "Copyright (C) 2014 The Florey Institute of Neuroscience and Mental Health, Melbourne, Australia. "

edit: and one more of a similar kind

$> grep Copyright cmd/tckglobal.cpp
 * Copyright (c) 2008-2018 the MRtrix3 contributors.
  COPYRIGHT = "Copyright (C) 2015 KU Leuven, Dept. Electrical Engineering, ESAT/PSI,\n"
yarikoptic commented 6 years ago

also it is not clear what were the original conditions/terms since they aren't included, e.g. mentioned in:

  COPYRIGHT = "Copyright (C) 2015 KU Leuven, Dept. Electrical Engineering, ESAT/PSI,\n"
              "Herestraat 49 box 7003, 3000 Leuven, Belgium \n\n"

              "This is free software; see the source for copying conditions.\n"
              "There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.";

or it was implied that it is the terms of mrtrix3 itself?

Thanks in advance for the clarification

thijsdhollander commented 6 years ago

No worries there, that's fully intentional. The copyright "field" there is something that authors of commands can fill in themselves, and it's the thing that's also shown when they run the command without parameters or options (i.e. the help page of it, so as to say). The headers at the top of the files are all the same (apart from a rare few, where we used the entire file from somewhere else), and all just mention "the MRtrix3 contributors" as a bit of an easy "capture-all" kind of group... especially now that a lot of the files containing the code have a long history of contributions from several different developers.

About the ones that you bring up: fod2dec is entirely my work, and I'm 100% happy with the current copyright message mentioning the Florey Institute there. tckglobal is entirely @dchristiaens work, which was developed while he was at the KU Leuven. It's quite common that the institute / department / university / ... where a scientist works, in principle owns their scientific contributions, so that copyright field allows to indicate this where desired.

So well, all of this to say that the things you spotted aren't by mistake or anything; happy to leave them as such.