write_mrtrix_tsf: undefined/removed variable 'tracks'

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density

http://www.mrtrix.org

Mozilla Public License 2.0

294 stars 181 forks source link

write_mrtrix_tsf: undefined/removed variable 'tracks' #2521

Open diffusionmri opened 2 years ago

diffusionmri commented 2 years ago

Hi, In the function [matlab/write_mrtrix_tsf.m], 'tracks.XXX' should be 'tsf.XXX', since the variable 'tracks' was removed. See lines 41-43 and line 29.

Lestropie commented 2 years ago

Thanks for the report @diffusionmri.

Looks like the error was introduced in #2455, specifically in 42173769b, which erroneously duplicates the contents of 7cc090a49 from write_mrtrix_tracks.m into write_mrtrix_tsf.m.

Did you have any interest in committing the fix yourself? There's contribution instructions here.

Otherwise: @fionaEyoung?

fionaEyoung commented 2 years ago

Woops my bad! 😬 @diffusionmri would you be able to verify that nothing else is broken after the changes in #2522? I don't work with TSF files myself so might be missing some other obvious issue...