search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
294 stars 181 forks source link

Test Python 3.7 compatibility #2821

Open Lestropie opened 8 months ago

Lestropie commented 8 months ago

With 3.1.0, support for Python 2 is being removed (#2215).

With #2678. the minimum version will go up to 3.7 due to the use of f-strings. However I can't guarantee off the top of my head with 100% assurance that 3.1.0 will work on Python 3.7.

I'd like to add a CI test, probably in conjunction with #2154, that builds a Python 3.7 environment and does some degree of testing of Python scripts. This would ensure that the documented lower bound of support is in fact accurate.

daljit46 commented 8 months ago

The setup-python action may be useful for implementing this. IMO, it's a good idea to run a small set of tests with the minimum supported version (similarly to how we test the CI builds with CMake 3.16).