Fix the execution of NPY tests - Githubissues

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density

http://www.mrtrix.org

Mozilla Public License 2.0

291 stars 179 forks source link

Fix the execution of NPY tests #2842

Closed daljit46 closed 7 months ago

daljit46 commented 7 months ago

As mentioned in #2836, when #2437 was merged, NPY tests were mistakenly added to the codebase without accounting for the new testing structure post CMake. This PR aims to address that following the discussion in #2836. In particular, the CMake logic for our "unit tests" and any executables (under testing/tools) used by a test has now been modified to account for Python files.

github-actions[bot] commented 7 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 7 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 7 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 7 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 7 months ago

clang-tidy review says "All clean, LGTM! :+1:"

Lestropie commented 7 months ago

Did just a little bit of re-arrangement.

Renamed from "Python tests" to "Bash tests". These are not Python tests. They are tests that make use of a combination of C++ and Python tools to evaluate a particular C++ capability. The test invocations themselves are just Bash. They differ from the other "unit tests" in that there is no longer a direct correspondence between tool name (as a .cpp file) and execution of the binary compiled from that file as the test itself.
The tests initially failed. This happened because function add_bash_tests() defined in cmake/BashTests.cmake is utilised. This function treats each individual line of the input file as an individual test, and explicitly inserts "cleanup" jobs at the head and tail of this list; essentially replicating the behaviour of the old run_tests script. It does this by erasing tmp* and -tmp- relative to the data directory. But for the unit tests, no such data directory existed. For now I've just set it to use the source directory as the data directory; but in #2678 there will be a new directory for storing data relevant to "unit tests".