MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
291 stars 179 forks source link

Python: Switch to double-quotes throughout & enforce #2852

Open Lestropie opened 7 months ago

Lestropie commented 7 months ago

I don't recall what decision making process I may have gone through at the time regarding string quoting in Python. But at some point I landed on using single quotes throughout. I've noticed recently in population_template that there's a mixture of single and double quotes.

I wonder if converting everything to double quotes would make sense, given it shares a repository with C++ code, where single quotes are for individual characters.

It would not require escape characters for apostrophes contained within strings; conversely, there are many instances of quoting text within strings that are probably most appropriately done using double-quotes, and so those would need to be escaped.

While pylint does not seem to be able to enforce one particular convention, it does at least allow for reporting a problem if a string is quoted using a character other than what appears to be the convention for the rest of the file.

Does anyone feel particularly strongly one way or another?