Closed daljit46 closed 2 months ago
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
I've updated the testing instructions to reflect the latest changes in testing code. @Lestropie could you please have a look and see if there's anything that's missing and/or incorrect?
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
clang-tidy review says "All clean, LGTM! :+1:"
I think you've removed the section on using a local clone to download the test data. Shall we omit that in the testing readme? I think it'd be for that mechanism to be documented somewhere at least.
Good catch. Think I failed to move it partway through, then erroneously deleted it entirely when I had to do an explicit rebase.
clang-tidy review says "All clean, LGTM! :+1:"
This seems to be good to go IMO, so will merge soon.
Addresses #2826. Testing tips and instructions have been updated to reflect the transition to CMake. Sections on the handling of testing data assume #2848 has been merged. Some instructions may not be clear or need removing due to the fact that some of the concerns/workflows no longer apply with the transition to CMake.
It's still WIP.