Update testing README - Githubissues

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density

http://www.mrtrix.org

Mozilla Public License 2.0

291 stars 179 forks source link

Update testing README #2855

Closed daljit46 closed 2 weeks ago

daljit46 commented 7 months ago

Addresses #2826. Testing tips and instructions have been updated to reflect the transition to CMake. Sections on the handling of testing data assume #2848 has been merged. Some instructions may not be clear or need removing due to the fact that some of the concerns/workflows no longer apply with the transition to CMake.

It's still WIP.

github-actions[bot] commented 7 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 5 months ago

clang-tidy review says "All clean, LGTM! :+1:"

daljit46 commented 3 weeks ago

I've updated the testing instructions to reflect the latest changes in testing code. @Lestropie could you please have a look and see if there's anything that's missing and/or incorrect?

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

Lestropie commented 3 weeks ago

There are now labels both for language and for each command name, so no need to use regexes.
There were still some out-of-date references to being one test per line of a test script file, predating #2865.
The later text read like it was written when we first added the testing. I've replaced it with something new describing how I typically go about it these days.

daljit46 commented 3 weeks ago

I think you've removed the section on using a local clone to download the test data. Shall we omit that in the testing readme? I think it'd be for that mechanism to be documented somewhere at least.

Lestropie commented 3 weeks ago

Good catch. Think I failed to move it partway through, then erroneously deleted it entirely when I had to do an explicit rebase.

github-actions[bot] commented 3 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"

daljit46 commented 2 weeks ago

This seems to be good to go IMO, so will merge soon.