search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
291 stars 179 forks source link

GLM: Temporarily disable Z-statistic lookup table use #2874

Open Lestropie opened 5 months ago

Lestropie commented 5 months ago

Until I can find the time to implement the more exhaustive fix in #2868, I believe that doing this change in conjunction with the merge of #2866 should be adequate to address the threading race condition reported in #2857.

I don't recall exactly how much time efficiency is gained from use of lookup tables for this operation; I'll see if I can quickly rig up a timing test.

github-actions[bot] commented 5 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 5 months ago

clang-tidy review says "All clean, LGTM! :+1:"