search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
291 stars 179 forks source link

Use LLVM linker on Linux if available #2875

Closed daljit46 closed 5 months ago

daljit46 commented 5 months ago

Enables the use of the LLVM linker by default on Linux platforms. It is much faster than the standard GNU linker and can provide a significant improvement in linking time, especially in incremental builds.

github-actions[bot] commented 5 months ago

clang-tidy review says "All clean, LGTM! :+1:"

Lestropie commented 5 months ago

Does this require explicit test with cmake pre & post 3.29, or is that already done / duplicated code from elsewhere that you're confident to merge immediately? (I'm happy for you to merge if you are, just posing the question)

daljit46 commented 5 months ago

I think this set of changes is fairly standard (I've seen other projects using something similar). For CMake 3.29 (which is already available using pip install cmake), I've tested this and it works as intended. Ideally, at some point (probably years ahead I guess) the code for prior versions will be removed.