Fix drag & drop on Windows for mrview

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density

http://www.mrtrix.org

Mozilla Public License 2.0

291 stars 179 forks source link

Fix drag & drop on Windows for mrview #2886

Closed daljit46 closed 1 month ago

daljit46 commented 5 months ago

Should address #1373

daljit46 commented 4 months ago

To address your comment, I've now introduced a new MR::GUI::MRView::QtHelpers namespace which contains a url_to_std_string helper function that is used when handling drop events. One thing I'm not sure is where should qthelpers.h should reside. Currently, it's in src/gui/mrview but perhaps it makes more sense in src/gui?

github-actions[bot] commented 4 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 4 months ago

clang-tidy review says "All clean, LGTM! :+1:"

Lestropie commented 2 months ago

Tried to test, but for some reason libmrtrix-gui.dll was not built. Fresh build directory, QT5. Will continue trying.
I think that this would be better targeted at master rather than dev given that it is a bug fix.

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

daljit46 commented 2 months ago

Do maintain this should be back-propagated to master. But given the code formatting changes would cause conflicts across the board, could maybe merge this, manually re-implement on master, and then on dev accept only the dev-based change?

Sounds good to me.

github-actions[bot] commented 1 month ago

clang-tidy review says "All clean, LGTM! :+1:"