search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
291 stars 179 forks source link

Fix launching mrview from build directory on Windows #2887

Closed daljit46 closed 4 months ago

daljit46 commented 5 months ago

Changes output location of mrtrix-gui to ensure that mrview launches correctly in a MSYS2 environment.

github-actions[bot] commented 5 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 5 months ago

clang-tidy review says "All clean, LGTM! :+1:"

Lestropie commented 4 months ago

On my own Windows system, running mrview without this change does nothing; no window opens, and control returns to the terminal. However I can't confirm that this change results in successful execution, as on my own system mrview immediately experiences a segmentation fault. And I'm having other issues trying to compile in debug mode to diagnose. Content to have this merged if you're confident in the change, I just can't confirm the fix myself right now.

github-actions[bot] commented 4 months ago

clang-tidy review says "All clean, LGTM! :+1:"

daljit46 commented 4 months ago

On my own Windows system, running mrview without this change does nothing; no window opens, and control returns to the terminal.

Perhaps #2884 also needs to be applied?