MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
281 stars 176 forks source link

-json_export: Fix slice encoding direction sign #2900

Open Lestropie opened 1 month ago

Lestropie commented 1 month ago

Erroneous sign flip appears to trace all the way back to 909ccab81b659cfb42eac08e1bf1cd814836f98c here, which came in #1175, so it appears to have been there ever since capturing of slice encoding information was added.

I discovered this during a larger experiment verifying the handling of DWI metadata, which involves processing data from 24 DWI acquisitions, with every possible combination of slice orientation, slice order ("ascending" vs. "descending"), and phase encoding direction. This changes makes the output of mrconvert from an input DICOM series commensurate with both the outputs from dcm2niix and the orientations indicated in the SeriesDescriptions.

In terms of consequences: