search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
294 stars 181 forks source link

Add missing windows.h include header #2913

Closed daljit46 closed 6 months ago

daljit46 commented 6 months ago

Including src/gui/opengl/gl_core_3_3.h should automatically include windows.h if APIENTRY is not defined. Still, some libraries (e.g., the latest versions of Qt) define this macro without including windows.h in their public headers (to avoid polluting the global namespace). Since this issue is currently preventing the merging of PRs on dev, a quick solution that explicitly includes <windows.h> is added to deal with this. Ideally, no public header should automatically include windows.h, so a more robust approach is warranted here. We could either wrap the header to prevent the propagation of windows.h or replace it with something else. Will try to address this in a future PR.

github-actions[bot] commented 6 months ago

clang-tidy review says "All clean, LGTM! :+1:"