search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
281 stars 176 forks source link

OpenGL: Minimise what is imported by windows.h #2914

Closed Lestropie closed 1 month ago

Lestropie commented 1 month ago

Extension of #2913.

Tried to quickly read up on the topic. It is considered most severely problematic to not define NOMINMAX, but there's strong disdain generally for including windows.h rather than sub-components thereof. As stated in #2913 this could be done, but would require more effort. What I thought I'd try here is throw in some #defines that are intended to disable certain components of windows.h that are commonly not required. This specific list I pulled from here, but have seen various references to these in different places.

github-actions[bot] commented 1 month ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 1 month ago

clang-tidy review says "All clean, LGTM! :+1:"