Remove all instance of NULL

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density

http://www.mrtrix.org

Mozilla Public License 2.0

281 stars 176 forks source link

Remove all instance of NULL #2925

Open Lestropie opened 2 weeks ago

Lestropie commented 2 weeks ago

Came to mind reviewing #2911, which removes some but not all usage.

NULL is legacy C macro; looks like from C++11 it should be defined as nullptr, but nullptr is the better syntax I think.

[ ] Replace instances of NULL with nullptr where relevant
[ ] Change code structure to no longer be based on null-terminated pointer arrays where possible
[ ] Have check_syntax check for bad use of NULL

daljit46 commented 2 weeks ago

This should be fairly easy to do. Clang-tidy already has a check for this modernize-use-nullptr. We can probably add it our .clang-tidy.