MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
281 stars 176 forks source link

Fixes to containers FSL dependency #2929

Open Lestropie opened 2 weeks ago

Lestropie commented 2 weeks ago

Closes #2921.

See also https://github.com/MRtrix3/containers/pull/26, which includes changes necessary to produce the minified FSL dependency that this change then downloads from OSF.

While the container minification process intended to capture EddyQC's eddy_quad, the fact that it was not being properly executed was missed because dwifslpreproc does not return non-zero if it fails to execute.

Unfortunately I couldn't easily resolve just this one thing. I've ended up having to update the FSL version as well. Which is not fantastic for a patch MRtrix update, since there's some chance of a change in behaviour out of our control.

Regarding #2921, if this change is deemed acceptable I can push it to DockerHub as latest, which would make it easy for people to access immediately but without necessitating an MRtrix patch update.

Lestropie commented 2 weeks ago

@anaharrismatnez @jhuguetn: If you want to try mrtrix3/mrtrix3:eddyqcfix on DockerHub, that should allow dwifslpreproc to run eddy_quad.

jhuguetn commented 2 weeks ago

That's great, thanks @Lestropie! We will and will give you some feedback.
One single doubt after quickly reviewing the changes proposed in both ends (the image for building the minified FSL package and the main MRtrix3 image), in the former you used ANTs 2.5.2 while in the later the version of ANTs installed is the same as it was previously, release 2.3.4.
Could that have any undesired effect on the usage of the final MRtrix3 image that you might think of?

Lestropie commented 2 weeks ago

The minification container is now pulling a newer version of ANTs because the existing version was failing to compile (don't recall the specifics, but every time I tried to change one thing to get minification to work something else broke). However that change was only made for the sake of allowing me to re-run the minification process for FSL. That updated ANTs version has not been uploaded to OSF, and the MRtrix3 container continues to download the same minified version of ANTs as the 3.0.4 version of the container. That's intentional; I'd rather put off an update to a dependency until a minor version update.

anaharrismatnez commented 2 weeks ago

Thanks @Lestropie, we were able to run dwifslpreproc with eddy_quad perfectly using mrtrix3/mrtrix3:eddyqcfix. The only thing is that every time I run a command I get the following message any idea why it could be? /bin/bash: /opt/fsl/lib/libtinfo.so.6: no version information available (required by /bin/bash)

daljit46 commented 2 weeks ago

Most likely, that warning is due to the issue mentioned in this post.

Lestropie commented 1 week ago