Open Lestropie opened 2 weeks ago
@anaharrismatnez @jhuguetn: If you want to try mrtrix3/mrtrix3:eddyqcfix
on DockerHub, that should allow dwifslpreproc
to run eddy_quad
.
That's great, thanks @Lestropie! We will and will give you some feedback.
One single doubt after quickly reviewing the changes proposed in both ends (the image for building the minified FSL package and the main MRtrix3 image), in the former you used ANTs 2.5.2 while in the later the version of ANTs installed is the same as it was previously, release 2.3.4.
Could that have any undesired effect on the usage of the final MRtrix3 image that you might think of?
The minification container is now pulling a newer version of ANTs because the existing version was failing to compile (don't recall the specifics, but every time I tried to change one thing to get minification to work something else broke). However that change was only made for the sake of allowing me to re-run the minification process for FSL. That updated ANTs version has not been uploaded to OSF, and the MRtrix3 container continues to download the same minified version of ANTs as the 3.0.4
version of the container. That's intentional; I'd rather put off an update to a dependency until a minor version update.
Thanks @Lestropie, we were able to run dwifslpreproc
with eddy_quad
perfectly using mrtrix3/mrtrix3:eddyqcfix.
The only thing is that every time I run a command I get the following message any idea why it could be?
/bin/bash: /opt/fsl/lib/libtinfo.so.6: no version information available (required by /bin/bash)
Most likely, that warning is due to the issue mentioned in this post.
libtinfo.so
warning before merging
I saw this myself also, just forgot to list it here, and prioritised getting something functional for you.
Closes #2921.
See also https://github.com/MRtrix3/containers/pull/26, which includes changes necessary to produce the minified FSL dependency that this change then downloads from OSF.
While the container minification process intended to capture EddyQC's
eddy_quad
, the fact that it was not being properly executed was missed becausedwifslpreproc
does not return non-zero if it fails to execute.Unfortunately I couldn't easily resolve just this one thing. I've ended up having to update the FSL version as well. Which is not fantastic for a patch MRtrix update, since there's some chance of a change in behaviour out of our control.
Regarding #2921, if this change is deemed acceptable I can push it to DockerHub as
latest
, which would make it easy for people to access immediately but without necessitating an MRtrix patch update.