MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
294 stars 181 forks source link

Changes to pre-downloaded external dependencies #2980

Open Lestropie opened 2 months ago

Lestropie commented 2 months ago

From Reviewing #2979, but listing separately as it's not critical there.

daljit46 commented 2 months ago

I think the cleanest way to go about this would be to have separate directories for each dependency. This provides better encapsulation and allows for CMake targets to only include headers that they link against (e.g. if we place all headers in the same directory, then a target linking against half::half will have access to all the other headers too). Not really a big issue, but I believe it's less idiomatic than having separate directories per dependency.