search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
294 stars 181 forks source link

Disable the use of LLD by default #2989

Closed daljit46 closed 2 months ago

daljit46 commented 2 months ago

We no longer use LLD by default if it is available for reasons mentioned in #2986. The use of LLD can now be enabled by using -DMRTRIX_USE_LLD=ON. This option only exists as a convenience and will be removed once our target CMake version matches 3.19 or higher (as we will be able to leverage CMake presets to achieve the same thing). Additionally, we use CMake's check_cxx_compiler_flag to see if the compiler supports LLD regardless of the platform (instead of simply relying on the presence of ld.lld).

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"