search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
294 stars 181 forks source link

Fix git version mismatch logic with shallow clones #3006

Closed daljit46 closed 2 months ago

daljit46 commented 2 months ago

The logic in FindVersion.cmake uses git describe to find the git commit and tags of the project. Previously, we were mistakenly aborting the configuration of the project when git describe returned an error. This PR fixes that by checking the version mismatch only if the parsing of the git tag and commit is successful. A warning is emitted otherwise. Closes #3000

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

github-actions[bot] commented 2 months ago

clang-tidy review says "All clean, LGTM! :+1:"

daljit46 commented 2 months ago

@Lestropie Sometimes the binary tests for dirrotate fail on our CI. The failure doesn't seem to be deterministic because it doesn't always happen, but I have seen it also in other PRs.