search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
294 stars 181 forks source link

App::get_options(): Assert correct usage #3032

Open Lestropie opened 2 weeks ago

Lestropie commented 2 weeks ago

This is intended to catch cases where a developer erroneously includes the leading dash character in the name of a command-line option when invoking the App::get_options() or App::get_option_value() function.

The runtime of dwidenoise in #3029 was observed to not be varying as a function of kernel radius due to the bug in 7c8fc048fb8583af75a7fe6bb8b006a9f3224c7e. This change is intended to catch such coding errors more directly and immediately.

github-actions[bot] commented 2 weeks ago

clang-tidy review says "All clean, LGTM! :+1:"