search

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density
http://www.mrtrix.org
Mozilla Public License 2.0
294 stars 181 forks source link

[ENH] Update Dockerfile #3039

Open arnaudbore opened 1 day ago

arnaudbore commented 1 day ago

Dockerfile has not been update for quite some time, I based my modifications on your branch container_eddyqc_fix and based the whole container on the non slim version of python3.8 to get more core system commands.

Lestropie commented 1 day ago

Is there a way to add just the requisite runtime system dependencies to the image recipe rather than resorting to the non-slim base? If it’s just a couple of things missing here and there, it’d be preferable to add those explicitly, just to keep the size as small as possible. If it’s a very long list, or the reduction in size that would be achieved is minimal, then just adopting the non-slim base is justified.

arnaudbore commented 1 day ago

Thanks for the quick review, I'm going to check. I also sent you an email and put @jdtournier in cc for more context.

Lestropie commented 4 hours ago

Ah OK; this is actually a superset of #2929. Clearly there I made the decision that along with fixing how the dependencies are captured I also wanted to increment the dependency version. I'd prefer to merge #2929 first, after which this PR should show only the proposed change that is specific to your need.