tckconvert vtk tests fail on windows

MRtrix3 / mrtrix3

MRtrix3 provides a set of tools to perform various advanced diffusion MRI analyses, including constrained spherical deconvolution (CSD), probabilistic tractography, track-density imaging, and apparent fibre density

http://www.mrtrix.org

Mozilla Public License 2.0

290 stars 179 forks source link

tckconvert vtk tests fail on windows #613

Open bjeurissen opened 8 years ago

bjeurissen commented 8 years ago

Noticed the master branch tckconvert tests fail on Windows:

## running "tckconvert"...
# command: tckconvert tracks.tck tmp.vtk -force && diff tmp.vtk tckconvert/out0.vtk [ ERROR ]
tckconvert: [WARNING] existing output files will be overwritten
# command: tckconvert tracks.tck -scanner2voxel dwi.mif tmp.vtk -force && diff tmp.vtk tckconvert/out1.vtk [ ERROR ]

Lestropie commented 8 years ago

From memory the issue was that the tracks are not guaranteed to appear in the same order at the output due to multi-threading, but the test is a simple file diff rather than looking for matching tracks. Should probably just disable threading for the test, at least for now.

Lestropie commented 8 years ago

As mentioned in #712 and this community forum post, this is probably no longer a multi-threading issue but an integer-to-string precision issue. I've got a funny feeling that manually setting this precision is interpreted differently by the MSYS2 libraries.