Closed xirothehero closed 7 years ago
1) That's fine 2) That's fine. I'm only using one drawable folder too
3) Layout gets messed up in landscape orientation lol
Disable landscape app wide. There should be an easy way to do that
I got it
@xirothehero Can you attach a screenshot?
@zuhairp @xirothehero I'm about to compile it so I'll attach them (unless Ali was already on it)
I put a screenshot on Slack, gonna try something to lock orientation
This isn't too bad...
So should I commit the orientation lock stuff or no?
Yeah
@xirothehero Yeah. I'll let you do it
Also, delete :
D mobile/Client/Client.Droid/Resources/layout/fragment_annoucements.axml D mobile/Client/Client.Droid/Screens/AnnoucmentsFragment.cs
Notice the mispelling in the name. They are leftover files
Also the url is msa-texas.org - I totally screwed that up in iOS... (it opens the right page though)
Reviewing
@saad ok I see dem. Is delete =/= remove?
Did you fix the URL?
@zuhairp yeah
@zuhairp forgot about that..
I see that you did
Also it says I'm not authorized to merge
jk.. I push the button then
1) For TW/FB goes to web. Idk if that's just my phone or b/c idk how to filter intent for other apps 2) Icons not in other drawable-~~~ files
other than that i think it's ok