MSA-Lone-Star-Council / 2019-showdown

The app for MSA Showdown, hosted by Lone Star Council
2 stars 0 forks source link

Acknowledgments android #104

Closed xirothehero closed 7 years ago

xirothehero commented 7 years ago

1) For TW/FB goes to web. Idk if that's just my phone or b/c idk how to filter intent for other apps 2) Icons not in other drawable-~~~ files

other than that i think it's ok

Saadnajmi commented 7 years ago

1) That's fine 2) That's fine. I'm only using one drawable folder too

xirothehero commented 7 years ago

3) Layout gets messed up in landscape orientation lol

Saadnajmi commented 7 years ago

Disable landscape app wide. There should be an easy way to do that

Saadnajmi commented 7 years ago

I got it

zuhairp commented 7 years ago

@xirothehero Can you attach a screenshot?

Saadnajmi commented 7 years ago

@zuhairp @xirothehero I'm about to compile it so I'll attach them (unless Ali was already on it)

xirothehero commented 7 years ago

I put a screenshot on Slack, gonna try something to lock orientation

Saadnajmi commented 7 years ago

screenshot_20170410-002641 1

This isn't too bad...

xirothehero commented 7 years ago

So should I commit the orientation lock stuff or no?

zuhairp commented 7 years ago

Yeah

Saadnajmi commented 7 years ago

@xirothehero Yeah. I'll let you do it

Also, delete :

D mobile/Client/Client.Droid/Resources/layout/fragment_annoucements.axml D mobile/Client/Client.Droid/Screens/AnnoucmentsFragment.cs

Notice the mispelling in the name. They are leftover files

zuhairp commented 7 years ago

Also the url is msa-texas.org - I totally screwed that up in iOS... (it opens the right page though)

Saadnajmi commented 7 years ago

Reviewing

xirothehero commented 7 years ago

@saad ok I see dem. Is delete =/= remove?

zuhairp commented 7 years ago

Did you fix the URL?

xirothehero commented 7 years ago

@zuhairp yeah

Saadnajmi commented 7 years ago

@zuhairp forgot about that..

zuhairp commented 7 years ago

I see that you did

xirothehero commented 7 years ago

Also it says I'm not authorized to merge

Saadnajmi commented 7 years ago

jk.. I push the button then