search

MSD-LIVE / issues

0 stars 0 forks source link

allow tables in RDM description fields #113

Open zguillen opened 1 year ago

zguillen commented 1 year ago

RDM took that button out of the editor instead of fixing it This is their ticket: deposit form: description text editor allows tables, but it should not be allowed and landing pages strips them out · Issue #596 · inveniosoftware/invenio-app-rdm (github.com) That implies that the fix is to edit this marshmallow class marshmallow-utils/marshmallow_utils/fields/sanitizedhtml.py at master · inveniosoftware/marshmallow-utils (github.com) But I don't see 'ALLOWED_HTML_TAGS' used anywhere so will need more digging.

zguillen commented 5 months ago

@jugovimm Maybe just take out that table button from the editor for now since it's worse to have it in there and not working that not have it at all. With the next RDM release we upgrade to we can try adding it back to see if they've included a new version of that package.

jugovimm commented 5 months ago

Final action: removed table button from editor. Invenio RDM has updated from using CKEditor to TinyMCE. Once we update our instance of Invenio RDM, we can explore using / adding back in table functionality

TinyMCE editor example: https://www.tiny.cloud/docs/demo/full-featured/