search

MSD-LIVE / issues

0 stars 0 forks source link

better browser downloading to support larger than 1 GB max #209

Open zguillen opened 3 months ago

zguillen commented 3 months ago

We need to allow users to download more than 1GB from the browser. Currently we zip the files in the browser so we're limited by the browser's memory.

For testing purposes, here are some large test dataset ID's on dev with their respective total file sizes/counts (to save us from having to find/upload large/numerous files):

Image

zguillen commented 3 months ago

We don't have to zip if what the user has selected to download are only files, no dirs. Should we modify UI code to allow multiple file downloading even if the total size exceeds our max as long as no folders were selected to download? If so, then we just need to add logic to not zip in this case and perhaps alert the user before beginning the download to confirm that x number of files will be downloaded in their downloads dir or selected folder (it's a browser preference so hard to do wording here...)

Change error dialog message ("The selected download exceeds maximum size 1 GB and cannot be downloaded in your browser") to: "Your download contains folders, and so it must be zipped, but the zip cannot exceed 1GB. Please download files individually in your browser or use the MSD-LIVE CLI."

zguillen commented 3 months ago

Currently if a folder is selected for download but it only contains 1 file, only the file is downloaded, not the folder as a zip. So, the folder structure is lost. Is this ok/expected behavior?