MSEndpointMgr / ConfigMgr

Microsoft Endpoint Configuration Manager scripts and tools
634 stars 281 forks source link

Invoke-CMDownloadBIOSPackage.ps1 incorrectly determines the model covered by a BIOS package if the model name contains - characters #124

Closed vorlon77 closed 5 years ago

vorlon77 commented 5 years ago

There is a problem in Invoke-CMDownloadBIOSPackage.ps1 when the model names contain - characters. Models affected include the Dell "Latitude 3390 2-in-1" "Latitude 5290 2-in-1" "Latitude E5430 non-vPro". This issue should also affect the equivalent file that downloads drivers.

$PackageNameComputerModel = $Package.PackageName.Split("-").Replace($ComputerManufacturer, "").Trim()[1]

should be changed to

$PackageNameComputerModel = $Package.PackageName.Split("-",2).Replace($ComputerManufacturer, "").Trim()[1]
NickolajA commented 5 years ago

Fixed in Invoke-CMDownloadBIOSPackage.ps1 version 2.1.1. Invoke-CMApplyDriverPackage.ps1 2.2.2, which is recently released does not contain this issue.