MSEndpointMgr / ConfigMgr

Microsoft Endpoint Configuration Manager scripts and tools
633 stars 281 forks source link

Minor bug in Invoke-DellBIOSUpdate #137

Closed Ginolard closed 5 years ago

Ginolard commented 5 years ago

Another empty string problem ;)

Sensibly, you replace the $Password variable with "Password Removed" in the log output. However, if $password is empty because there's no BIOS password the output looks like this.

Using the following switches for Flash64W.exe: <password removed>/<password removed>b<password removed>=<password removed>D<password removed>:<password removed>\<password removed>s<password removed>o<password removed>u<password removed>r<password removed>c<p
assword removed>e<password removed>s<password removed>\<password removed>D<password removed>r<password removed>i<password removed>v<password removed>e<password removed>r<password removed>s<password removed>\<password removed>P<password removed>a<password rem
oved>c<password removed>k<password removed>a<password removed>g<password removed>e<password removed>s<password removed>\<password removed>D<password removed>e<password removed>l<password removed>l<password removed>\<password removed>L<password removed>a<pass
word removed>t<password removed>i<password removed>t<password removed>u<password removed>d<password removed>e<password removed> <password removed>5<password removed>2<password removed>5<password removed>0<password removed>\<password removed>B<password remove
d>I<password removed>O<password removed>S<password removed>\<password removed>A<password removed>2<password removed>0<password removed>\<password removed>5<password removed>2<password removed>5<password removed>0<password removed>A<password removed>2<passwor
d removed>0<password removed>.<password removed>e<password removed>x<password removed>e<password removed> <password removed>/<password removed>s<password removed> <password removed>/<password removed>l<password removed>=<password removed>C<password removed>:
<password removed>\<password removed>t<password removed>e<password removed>m<password removed>p<password removed>\<password removed>l<password removed>o<password removed>g<password removed>.<password removed>l<password removed>o<password removed>g<password r
emoved>

Not a big deal as it doesn't stop the BIOS being updated - just annoying to read ;)

NickolajA commented 5 years ago

Should be fixed in 1.1.0, thank you for reporting this.

Ginolard commented 5 years ago

No problem. Glad to help support this project! It's been of huge benefit to us

On Tue, 14 May 2019 at 10:31, Nickolaj Andersen notifications@github.com wrote:

Closed #137 https://github.com/SCConfigMgr/ConfigMgr/issues/137.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SCConfigMgr/ConfigMgr/issues/137?email_source=notifications&email_token=ACD4K5DULXN6BZX7QFLYXSTPVJ2ENA5CNFSM4HMWUXG2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORNXNAZA#event-2339295332, or mute the thread https://github.com/notifications/unsubscribe-auth/ACD4K5AX2S25RZCNDB7XGITPVJ2ENANCNFSM4HMWUXGQ .