search

MSEndpointMgr / IntuneAppFactory

Intune App Factory automates Win32 application packaging in Intune.
https://msendpointmgr.com/intune-app-factory
MIT License
36 stars 11 forks source link

Upgrade framework psadt to 3.9.3 #8

Open nithilin1 opened 1 year ago

DennisBergemann commented 1 year ago

Hello @nithilin1 , Allow me one question. do you think this can work?

I ask because you changed only some files, but we had to change in our repo alll files.

From Version 3.7 to 3.9 they changed that you can work with files and BOM correctly ;-)

3.7 not worked in china, but 3.9

best regards

nithilin1 commented 1 year ago

Hi Dennis! I'm using it as we speak, and I've had no issues so far. Im pretty sure all I did was replace the framework files, and I brought along the install-application.ps1 files along with the templates in - 'cause they're good. :) Is there anything not working, or? BR Kevin

DennisBergemann commented 1 year ago

@nithilin1

Hi Kevin, we customized our own version of the factory and i updated the toolkit by myself. I wondered only because i can see in your pullrequest only some files changed and in my experience it will work fine for western countries, but i know that it was changes from 3.7 to 3.9 that the toolkit works fine for chinese ones as well and so it was only guess from my side.

and note the deployapplication.exe from 3.9 is much smaller, so i recommended for my own repo to update the full toolkit.

Its only a guess and i dont know if your change works.

We work with the latest release of the factory + our own modifications / customizations.

I love that project so much and thought only it would be helpfull.

Best Regards Dennis

nithilin1 commented 1 year ago

No problem! The passion for this is what drives the project forward. :) Could you upload a pull request with your files, then i'll have a look/compare and see. I'll be happy to close this pull request if yours is more suitable and better built! BR Kevin

DennisBergemann commented 1 year ago

No all your changes are correct, only the other files from the new 3.9 should be provided in my opinion as well.

Maybe add only those files from original 3.9 toolkit to your pullrequest

NickolajA commented 11 months ago

Hi @nithilin1, I'm not sure if I'm missing something here, and sorry for not answering earlier, but the files in this PR doesn't seem to be associated with the changes mentioned in the title. It looks to me like you've added a few new apps?

If you would like, I would highly like us all to submit their onboarded applications to a dedicated repo for others to share, so if you'd be kind enough to share what you've already used and tested with the rest, submit a PR here:

https://github.com/MSEndpointMgr/IntuneAppFactoryResources