MSEndpointMgr / ModernDriverManagement

Official repo of Modern Driver Management from MSEndpointMgr.com
https://www.msendpointmgr.com
MIT License
133 stars 80 forks source link

Microsoft SKU-detection not working #129

Open BlueToxic opened 3 years ago

BlueToxic commented 3 years ago

Some SKUs for Microsoft Surface devices contain a colon(:). This causes SKU detection to fail and fall back to computer model detection.

The line 1322 in Invoke-CMApplyDriverPackage.ps1 version 4.1.3 causes the issue. Specifically ".Split(":")".

Original line: SystemSKU = $DriverPackageItem.Description.Split(":").Replace("(", "").Replace(")", "")[1]

My current workaround is replacing it with this line, but there might be a better solution: SystemSKU = $DriverPackageItem.Description.Replace("(Models included:", "").Replace(")", "")

https://docs.microsoft.com/en-us/surface/surface-system-sku-reference

Mrgreen17 commented 3 years ago

Having same issue with surface pro 7 +, is there a way to fix the issue with the + symbol?

Thanks

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: BlueToxic @.> Sent: Friday, October 15, 2021 6:25:44 AM To: MSEndpointMgr/ModernDriverManagement @.> Cc: Subscribed @.***> Subject: [MSEndpointMgr/ModernDriverManagement] Microsoft SKU-detection not working (#129)

Some SKUs for Microsoft Surface devices contain a colon(:). This causes SKU detection to fail and fall back to computer model detection.

The line 1322 in Invoke-CMApplyDriverPackage.ps1 version 4.1.3 causes the issue. Specifically ".Split(":")".

Original line: SystemSKU = $DriverPackageItem.Description.Split(":").Replace("(", "").Replace(")", "")[1]

My current workaround is replacing it with this line, but there might be a better solution: SystemSKU = $DriverPackageItem.Description.Replace("(Models included:", "").Replace(")", "")

https://docs.microsoft.com/en-us/surface/surface-system-sku-reference

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/MSEndpointMgr/ModernDriverManagement/issues/129, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKNPEHJJ4G4HUDLUTM677TLUHATVRANCNFSM5GB7FDZA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

BlueToxic commented 3 years ago

Having same issue with surface pro 7 +, is there a way to fix the issue with the + symbol?

Thanks

Sent from my Verizon, Samsung Galaxy smartphone Get Outlook for Androidhttps://aka.ms/AAb9ysg

I haven't found a solution for SKU detection yet but if you make sure the package name in SCCM is "7+" and not "7Plus" it should match with Computer Model detection.

cbangen commented 2 years ago

Did anyone find a fix for this yet?

Mrgreen17 commented 2 years ago

@BlueToxic i never used "7plus" i always used "7+" and it still would not detect the package.

here is what i got so far:

driver package image

When i try the debug with version 4.13 of the script using this:

.\Invoke-CMApplyDriverPackage.ps1 -DebugMode -Endpoint "***" -UserName "**" -Password "****" -TargetOSVersion 20H2 -Manufacturer "Microsoft" -ComputerModel "Microsoft Surface Pro 7+" -SystemSKU "Surface_Pro_7+_with_LTE_Advanced_1961"

i get this in the log: image

it sees the driver package but will not match it. i had to create a completely separate task sequence just for this model and now have to maintain both. I had to use the apply driver package in the new Task sequence

image

benoitpatoux commented 1 year ago

Hi, I don't know if this error is followed but I adapted the script for the characters + for Microsoft devices if you want

Mrgreen17 commented 1 year ago

Hi Benoit, sorry for my ignorance but we're canni find your edited script.

Thank you