MSFREACH / msf-reach

Web platform for MSF-REACH
https://msf-reach.org/
4 stars 5 forks source link

'Project Code' field to be integrated #272

Open LucieGueuning opened 6 years ago

LucieGueuning commented 6 years ago

'Project Code' field needs to be added :

LucieGueuning commented 6 years ago

FYI, @anexact

matthewberryman commented 6 years ago

@LucieGueuning what is the form of the project code? A number? A mix of digits and letters? Is it fixed length?

LucieGueuning commented 6 years ago

ISO 2 of country code + 3 numbers would be the most common. Note that it might be duplication of code between of 2 different OCs. Can't be unique ID.

@qclin

matthewberryman commented 5 years ago

@LucieGueuning ready for testing in dev

LucieGueuning commented 5 years ago
  1. why is it in the event creation? Under monitoring, there is no 'Project Code' yet open.
  2. Please follow the shared file in drive (depending on status)
  3. not visible on event map modal
  4. there is no sentence if no project code

Please follow the requirements above

matthewberryman commented 5 years ago

I’ll review all items but not for map pop up the code here is to only display a code if there is one as the map pop ups are fairly space constrained.

Sent from my iPhone

On 14 Nov 2018, at 05:19, Lucie Gueuning notifications@github.com<mailto:notifications@github.com> wrote:

  1. why is it in the event creation? Under monitoring, there is no 'Project Code' yet open.
  2. Please follow the shared file in drive (depending on status)
  3. not visible on event map modal
  4. there is no sentence if no project code

Please follow the requirements above

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/MSFREACH/msf-reach/issues/272#issuecomment-438380809, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACLqbtV-U-v84iW5EyDgNliD64j_r_3yks5uuw0rgaJpZM4SW-Rz.

matthewberryman commented 5 years ago

why is it in the event creation? Under monitoring, there is no 'Project Code' yet open.

Removed from event creation

Please follow the shared file in drive (depending on status)

Fixed.

not visible on event map modal

Per above, because the landing map event popups are space constrained, from a UX perspective I think best just to omit it if not set. Or if you do want to always have it in the pop up, come up with something suggested than the suggested text (which is fine on events page but not for map pop up on landing).

there is no sentence if no project code

Fixed

LucieGueuning commented 5 years ago

All good. Perfect. Thanks!

Note that 'Project code' is coming only once we moved from explo to intervention. cf. spreadsheet