MSFREACH / msf-reach

Web platform for MSF-REACH
https://msf-reach.org/
4 stars 5 forks source link

Adding links on a per user basis #453

Closed LucieGueuning closed 5 years ago

LucieGueuning commented 6 years ago

Important feature to keep as such on GitHub. No duplication

matthewberryman commented 6 years ago

Per discussion on Skype:

  1. We already support RSS feed selection (from the existing feeds) on a per user basis. I assume you mean around adding new RSS feeds.
  2. Not every feed requested so far has been publicly accessible, nor have they all been RSS feeds - the TSR feed is just a web site that I have written separate code to parse as HTML (not RSS which is a dialect of XML) to extract the information from.
  3. It's not that common to have geospatial information (in georss format), without which we can't map the data, thus we would have to put into a table only. This would require rework of the code and rethink of the UX as we have a close integration between map and table in terms of selection of RSS feeds and also zooming to item on map on selection in table etc.
  4. There's been a lot of manual work (icon development and coding) customised to each RSS feed added so far to extract the information from the title, link, and summary information and use that in visually representing the information on the map for example some have disaster types, and additionally PDC has a status.
  5. Also applies to consistency of written representation in the table, too.

Particularly because of 3, but also supporting user preferences around RSS feeds and display, I am wondering why an RSS feed reader application and/or bookmarks bar cannot be used alongside REACH instead, e.g. as per following screenshot. To do this task would require writing a whole new full featured RSS feeder (that can save individual preferences, do scheduled polling rather than our on-demand "hack") etc.

screenshot 2018-05-31 13 38 40

For reference, particularly on illustrating some of the above issues, tagging specific requests https://github.com/MSFREACH/msf-reach/issues/395 https://github.com/MSFREACH/msf-reach/issues/384 https://github.com/MSFREACH/msf-reach/issues/127 https://github.com/MSFREACH/msf-reach/issues/271

matthewberryman commented 6 years ago

Speaking with Remi; for other regions https://github.com/MSFREACH/msf-reach/issues/455 sounds like we do need to replicate /embed some RSS reader features within REACH at some point. So need to think about workload around database, UI and API changes on that front. And need to promote use of georss. https://github.com/MSFREACH/msf-reach/issues/417

matthewberryman commented 6 years ago

@anexact need your UX feedback on how we do this

matthewberryman commented 6 years ago

Embedding RSS (incl non-geospatial) within the system (database and UX) could allow AI to leverage this information alongside everything else.

matthewberryman commented 6 years ago

@mehrdadgit I've made a start on this in https://github.com/MSFREACH/msf-reach/commit/16e7a525ac6e69c6b23e34dc2fd69bec1c0a6d0d and corresponding schema change https://github.com/MSFREACH/msf-reach-schema/commit/6bbe1e1cedabed82d449abb3f1fe4532f568dd11 Todo:

mehrdadgit commented 6 years ago

@matthewberryman I do not understand what is the markdown field for ? Is this the name/title of RSS feed ? if so, why does it have to be in markdown format ? Also if bookmarks table is going to store the custom RSS Feeds for the user, should we store the feed URL somewhere, in the same (or separate) table ?

LucieGueuning commented 6 years ago

Requirements for RSS feed: On landing page:

On event page:

Does that make sense?

matthewberryman commented 6 years ago

@LucieGueuning

Just to be clear, we are doing first two items to satisfy 2b requirements, the rest is 2c extension work.

matthewberryman commented 6 years ago

@mehrdadgit The markdown field is for the full markdown text that specifies the full list of bookmarks (titles and urls), e.g.

* [MSF REACH](https://msf-reach.org)
* [My company web site](https://acrossthecloud.net)
* [My mechanical computer](https://brunsviga.io)

which renders as:

LucieGueuning commented 6 years ago

@matthewberryman

Ok well noted.

points 1 and 2 for Phase 2b point 3 for Phase 2 extension point 4 (event page): cover by Qiao and Paul UX/UI revamp package

mehrdadgit commented 6 years ago

should be ready for testing @matthewberryman

matthewberryman commented 6 years ago

@LucieGueuning ready for testing in the test environment (test.msf-reach.org) with starting default links per https://github.com/MSFREACH/msf-reach/issues/416 (note there seemed some overlap with ENSO links so I only added one to save a bit of space but can add others back in).

LucieGueuning commented 6 years ago

FEEDBACK:

matthewberryman commented 6 years ago

Synchronised map and table for RSS feed geo-enable

Separate issues, see #668 and #669

ability to customised the same way the geo-enable one. SOL: Having a second balck button next to the first one with: 'Open geospatial news feeds'. And then possibility to remove, add or edit the link for geo-enable. It then sends a request to add it manually to the map or can it be automatic? How can we have the customised RSS feed for geo spatial ones?

There are a number of design & new / existing features requested in this item^^

  1. We have designed the geospatial tab as previously requested, and we talked about adding a button to open the non-geospatial ones. We could have two sub-tabs but that's a design decision for extension.
  2. We collate the links in the back end and can review for manual adding—given each one requires work (as discussed above and before we cannot auto add these), we do need to consider this carefully and collate data from multiple users; it would be a bit misleading to put a UI element in to specifically request manual addition.
  3. As you know, existing geoRSS feeds can be turned on and off.

Can we have an arrow to return back to edition, more user friendly. You don't want to close that window, you just want to go back to the previous one.

@mehrdadgit can add that button to go back from help to editing.

bug in the edit pop-up display:

This is not a bug but a way that the formatting language works. If you add any spacing between the [text] and the (link) then it shows them separately (with the long link overflowing). I've added some additional help text, in 89c4f0fcf5258b734a4c1a572e6589a5ab25735b , to clarify.

LucieGueuning commented 6 years ago

For the last comment: I know, imagine if the hyperlink is to keep and that long, it will be out of the box.

mehrdadgit commented 6 years ago

Gotcha @luciegueuning I will fix that.

mehrdadgit commented 6 years ago

Go back button and long-hyperlink-bug fixed; note it is on #174 branch.

LucieGueuning commented 5 years ago

Thanks Mehrdad. This can go to prod, to be confirmed with Matthew

matthewberryman commented 5 years ago

Great, I will move to prod tomorrow (my time) - just a bit busy this afternoon and I need to make sure I get the database changes in correctly for this one.

matthewberryman commented 5 years ago

@mehrdadgit I'll also need to go through and cherry-pick your latest commit over to the issues/453 branch to merge just that (while work proceeds on issues/174 branch).