search

MSFREACH / msf-reach

Web platform for MSF-REACH
https://msf-reach.org/
4 stars 5 forks source link

Bug in layout on event page #559

Closed LucieGueuning closed 6 years ago

LucieGueuning commented 6 years ago
  1. grey zone (to use same layout that the one for notification part)
  2. double line??
  3. text not squeeze to the zone
mehrdadgit commented 6 years ago

Note (1) has been fixed in #557 and https://github.com/MSFREACH/msf-reach/commit/1d7ce72a694f40e77ac2dd040db8e26781c8fedf

And (2) should be the result of scrollbar enabling in #557 and https://github.com/MSFREACH/msf-reach/commit/b487af4cef3cc5a1fe097ace3bdc7455f536bae7 can be reversed

I remember fixing (3) in #535 https://github.com/MSFREACH/msf-reach/commit/856329c85a05a538412dcfd82064ff8a9a494fc8 apparently it is lost now due to merge conflict resolutions...needs to be redone (easy -> colspan=2)

matthewberryman commented 6 years ago

@mehrdadgit re https://github.com/MSFREACH/msf-reach/commit/856329c85a05a538412dcfd82064ff8a9a494fc8 I found that trick wasn't handling long notifications properly either so I didn't worry too much about that in the merge (my work on that aspect). Feel free to have a quick go if you have time.

mehrdadgit commented 6 years ago

(3) done @matthewberryman

matthewberryman commented 6 years ago

thanks. I tried reverting https://github.com/MSFREACH/msf-reach/commit/b487af4cef3cc5a1fe097ace3bdc7455f536bae7 locally and it didn't solve the double lines. I think some css styling for tab-panes on events page to make them take the same space as the surrounding <div id="eventVApp"> should fix the double line issue?

@LucieGueuning the rest of the issues are fixed in dev test and prod now.

mehrdadgit commented 6 years ago

@matthewberryman @LucieGueuning if I understand correctly, we mean double "vertical" lines? I propose we keep them as their current state; they show a number of panels are inside a container in which they can be scrolled. if we push them to edges the panel headers will lose their shape IMO.

matthewberryman commented 6 years ago

good point

matthewberryman commented 6 years ago

I have fixed an issue where long sharepoint links could break the layout.

@LucieGueuning are we good to close this one now?

matthewberryman commented 6 years ago

@mehrdadgit there are still cases where there are URLs in notifications and it's wrapping properly (e.g. event ID 59 in prod)

mehrdadgit commented 6 years ago

on dev @matthewberryman