search

MSFREACH / msf-reach

Web platform for MSF-REACH
https://msf-reach.org/
4 stars 5 forks source link

Active Directory #57

Open anexact opened 7 years ago

anexact commented 7 years ago

MB posed question to IT officer CCh as follows:

Option 1 (preferred): Federation Services https://technet.microsoft.com/en-us/library/gg188612.aspx https://aws.amazon.com/blogs/mobile/announcing-saml-support-for-amazon-cognito/

Option 2 (less preferred): Passport Approach https://www.npmjs.com/package/passport-activedirectory

LucieGueuning commented 7 years ago

OPERATOR - ACTIVE DIRECTOR.xlsx

LucieGueuning commented 6 years ago

Confirm and double-check with Office 365 Support Team that 'password never expire'

LucieGueuning commented 6 years ago

to be done by Monday 19th of March (at least three permissions: viewers, operators, admin).

matthewberryman commented 6 years ago

@LucieGueuning just noting that this code is in dev branch but there are some logistical things and configuration things I need to work through with you and Richard before I activate it. For now it is working with the test login on our test site.

LucieGueuning commented 6 years ago

Great! do you want me to arrange a Skype call? or should I include Richard on the call tomorrow? Please let me know.

matthewberryman commented 6 years ago

No need to include Richard on the Skype call / have a separate one, can follow up by email (I have sent one to both of you with some follow up actions).

Sent from my iPhone

On 12 Mar 2018, at 21:01, Lucie Gueuning notifications@github.com<mailto:notifications@github.com> wrote:

Great! do you want me to arrange a Skype call? or should I include Richard on the call tomorrow? Please let me know.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/MSFREACH/msf-reach/issues/57#issuecomment-372254324, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACLqbuqZuokFOEI1eGvnU-ls1a8NbrBsks5tdkeIgaJpZM4O9CHi.

LucieGueuning commented 6 years ago

Ok, well noted. Thanks Matthew.

LucieGueuning commented 6 years ago

Great. Working well on production environment. To confirm:

Does that make sense?

matthewberryman commented 6 years ago

Correct.

That message won’t fit in the space of the buttons. It would be simpler maybe to just have an alert reminder pop up, and/or hide them (bearing in mind we discussed having a modal pop up on login to the system stating just that, in addition to any possible alerts).

Plus there are other UI things that need to change too, for example disabling double click for event creation.

@anexact

Sent from my iPhone

On 14 Mar 2018, at 22:53, Lucie Gueuning notifications@github.com<mailto:notifications@github.com> wrote:

Reopened #57https://github.com/MSFREACH/msf-reach/issues/57.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/MSFREACH/msf-reach/issues/57#event-1520745483, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACLqbmY7PKF3J1s02SY1I1OYwpU9KTHFks5teQSZgaJpZM4O9CHi.

LucieGueuning commented 6 years ago

ok good idea for having an alert reminder pop up, not hiding them. Go for it.

LucieGueuning commented 6 years ago

test with my gmail address: this is FYI. After adding me to the Operators group as guest (gmail address) For people outside the organisation, like TIC people for example. They will need to have a log in thanks to Cognito right?

image

matthewberryman commented 6 years ago

@LucieGueuning correct we will need to set up a separate environment (using Cognito for login), which can point to the same database.

matthewberryman commented 6 years ago

Just noting https://github.com/MSFREACH/msf-reach/issues/279 is issue for external parties.

matthewberryman commented 6 years ago

@LucieGueuning Just noting that double clicking still brings up event creation modal, and report status still shows up as a drop-down list, but as you go to confirm event / change status it will then pop up the modal. This is too much work in current phase to implement (I have other more pressing things) plus leaving it that way shows the functionality off even if people don't have access.

LucieGueuning commented 6 years ago

too much work to implement what? I don't understand, sorry

matthewberryman commented 6 years ago

Too much work to implement checks and changes to turn off the edit buttons and dropdowns client side.

LucieGueuning commented 6 years ago

need to be done, because it was open on time.

Thanks

anexact commented 6 years ago

This is a bad decision; please do not change it client side because it then doesn't show what the system can do. @LucieGueuning please put this on Monday agenda to discuss. (( Overall, IMO I think these types of decisions in the GitHub should be made more strategically and carefully so that the actual outcome is desirable for the platform, not because they were or were not put on a list at some point. ))

LucieGueuning commented 6 years ago

ok for being on the agenda on Monday

matthewberryman commented 6 years ago

Yes @luciegueuning we’d talked subsequently about leaving this aspect of it as is to show off those features (while not allowing submission of changes) and that seemed acceptable at the time. Please discuss further with @anexact Monday. The rest of this feature request is done.

LucieGueuning commented 6 years ago

linked to 'person in charge' field