search

MSFREACH / msf-reach

Web platform for MSF-REACH
https://msf-reach.org/
4 stars 5 forks source link

fixes #579 updateSection #590

Closed qclin closed 6 years ago

qclin commented 6 years ago

fixes #579

qclin commented 6 years ago

@matthewberryman can you confirm the fields in Extra Details

atm I set the fields as free input textarea, but for example Region, would that be enter from the map or is it still needed?

Selection dropdown for organisations or positions

also do the msf_response_non_medical_material fields still belong to EXTRA DETAILS, or are they now inside msf_responses?

matthewberryman commented 6 years ago
matthewberryman commented 6 years ago

@qclin I'm happy with your work on (1) in cd0c3b0 but still awaiting completion of (2) correct behaviour on cancellation.

qclin commented 6 years ago

@matthewberryman as I said reseting data to temp copy means atm some form of Jquery swapping on innerText/Value of every field most ideal would be to do a hard refresh per section, but right now it's all one long html

in https://github.com/MSFREACH/msf-reach/pull/590/commits/5bc63ae480bf475b7d223a9f6e693531c1747e3a I tried to clear the fields manually and let VUE model repopulate however this only works on the first cancel

mehrdadgit commented 6 years ago

@qclin @matthewberryman Note I tested https://github.com/MSFREACH/msf-reach/commit/5bc63ae480bf475b7d223a9f6e693531c1747e3a (in 537) does not work and is not a good practice anyway. @qclin If (2) is too much work, I suggest you do a page-refresh on cancel ( requires enforcing only one section is being edited at a time ) and then we can create a new issue for (2) @matthewberryman ?

matthewberryman commented 6 years ago

Thanks @mehrdadgit. @qclin can you please add a commit that wraps up (2) with a page cancel for now and I can re-open a new issue as suggested for a more elegant-looking fix.

Sent from my iPhone

On 26 Aug 2018, at 23:52, Mehrdad notifications@github.com<mailto:notifications@github.com> wrote:

@qclinhttps://github.com/qclin @matthewberrymanhttps://github.com/matthewberryman Note I tested 5bc63aehttps://github.com/MSFREACH/msf-reach/commit/5bc63ae480bf475b7d223a9f6e693531c1747e3a (in 537) does not work and is not a good practice anyway. @qclinhttps://github.com/qclin If (2) is too much work, I suggest you do a page-refresh on cancel ( requires enforcing only one section is being edited at a time ) and then we can create a new issue for (2) @matthewberrymanhttps://github.com/matthewberryman ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/MSFREACH/msf-reach/pull/590#issuecomment-416040495, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ACLqbvyRHcsAQwyuJlS94cOTBql7A0ilks5uUqgSgaJpZM4V4bHx.

qclin commented 6 years ago

@matthewberryman done, please merge and create new ticket for STORE function @mehrdadgit this will override the work you've done on stopEdits also on good practice, clearing the field and letting VUE repopulate is essentially what a hard refresh do

mehrdadgit commented 6 years ago

I did some ui polishes and also forced the user to edit one section at a time, otherwise the user clicks on Edit for two sections -> cancels on one -> refresh -> losing all the edited data in the other one. @matthewberryman ready to merge

matthewberryman commented 6 years ago

I've approved this and will merge into dev as I can't afford to hold up #612 however these changes break the display and saving of the severity sliders that will need to be fixed after I merge. I'll merge some other changes from dev -> master first before this merge, to not hold those up either.