move map into create new event modal

[qclin]

ref #368

@LucieGueuning this feeds into our conversation of moving double click to create event input fields into create new event modal

please confirm the filter fields

Monitoring / Exploration / Ongoing Intervention (MSF activity) / Complete of which Complete is Previous and where does Assessment fall ?

at the moment I have these

@matthewberryman @mehrdadgit while moving map into newEventModal, i notice some crumbs of newEventMap from before, was map originally inside modal?

if so how can i load the map correctly, it's only partially loading, even though I've call .invalidateSize()

[LucieGueuning]

Great! Let's wait for Natasha and Remi's feedback on next Monday before wasting time to develop it if they are not ok with that. ok?

[LucieGueuning]

but it si true, if it is only wording changes, it is ok! :)

[qclin]

@LucieGueuning this is from Natasha's feedback and you've all agreed to move map creation into modal as it's not the primary action of an operator's daily task. Would appreciate if you allow me some agency for design decisions. Thanks for confirming the categories.

[LucieGueuning]

Sure. I thought we wanted feedback on sketches from Remi and Natasha. Sorry for misunderstanding. Go ahead with that design decision without any doubt

[qclin]

@LucieGueuning Thanks @matthewberryman I would like to 1) have the popup be a fixed sidenav that collapse on & off when clicked, not mouse over 2) move the input fields of search by address & coordinates into the side panel like google maps let me know what's the best way to incorporate input field in the layout is it here in _initLayout https://github.com/MSFREACH/msf-reach/blob/issues/368/public/lib/leaflet/leaflet-src.js#L4880

since it is attached to address-autocomplete.js which jumps out of leaflet > validate from google map > resets view in leaflet is this the correct work flow?

[qclin]

@matthewberryman as you see in https://github.com/MSFREACH/msf-reach/pull/617/commits/0e8657142eb4fdca6a3fb5cb57136a822cfbb131 i try to make changes in the src file, but i don't think npm run build actually compiles the leaflet src files. need some pointers here

[matthewberryman]

@qclin from time to time I've been building leaflet separately from its source and leaflet-src.js is an intermediary file as part of its build process. Looking at its build steps it's just running uglifyjs:

➜ npm run build                                                   <aws:default>

> leaflet@1.3.1 build /Users/matthew/code/Leaflet
> npm run rollup && npm run uglify

> leaflet@1.3.1 rollup /Users/matthew/code/Leaflet
> rollup -c build/rollup-config.js

src/Leaflet.js → dist/leaflet-src.js, dist/leaflet-src.esm.js...
created dist/leaflet-src.js, dist/leaflet-src.esm.js in 1.2s

> leaflet@1.3.1 uglify /Users/matthew/code/Leaflet
> uglifyjs dist/leaflet-src.js -c -m -o dist/leaflet.js --source-map filename=dist/leaflet.js.map --in-source-map dist/leaflet-src.js.map --source-map-url leaflet.js.map --comments