Dates

[matthewberryman]

Can we take a look to ensure that all dates entered are being stored correctly and displayed correctly, especially on Safari (which doesn't always handle ISO 8601 properly, dependent on version).

[mehrdadgit]

This was both chrome and safari issue.

I fixed the date not saving/ showing correctly in the above commit for mission modal. There is still an issue that in edit-mode <date-picker> does not prefill with the current datetime!? still looking into it... . fixed now for departure and arrival times in the commit below.

@qclin I've ran out of time today; could you please double check all other dates in modals/event edits etc and make sure that date save/display functionality is working as it should ? (Note in DB sometimes dates are stored in different formats e.g. sometimes in 'DD/MM/YYYY' and sometimes as a full ISO string; I have handled both cases in my above commit (compare formatDateOnly and formatFullDate)

Plus note the trick in commit below when you want to capture time as well.

Also (re https://github.com/MSFREACH/msf-reach/commit/b7b04d7fb926d9f537490d586a625a0ed480734e ) @qclin is there an easy way to update landing page without hard refresh on mission edits? if not could we do the page refresh just when the modal is closed; it is very annoying at its current state.

[qclin]

@mehrdadgit you can close the modal and call load mission table again

[matthewberryman]

@mehrdadgit @qclin Just noting this issue applies to all dates not those on missions modal. There are a number of issues still:

• Suggested close date on event close has month and day swapped around.
• Event start and close dates not copied to any mission fields on close.
• Mission has uneditable open and close on left hand side of modal and these aren't correct.
• Duplication of event closure on mission modal.

[matthewberryman]

Also opened date invalid

[matthewberryman]

Just noting since fix for #635 and #632 removed event closure date prompt, we probably need to prompt for that on event completion status change in event editing panel.

[matthewberryman]

Re-opening to track display of mission end, if present, otherwise close date, properly in table.

[matthewberryman]

@LucieGueuning ready for review in test environment

[LucieGueuning]

wording should be (for consistency):

• End date of MSF response
• Closure Date of event

[matthewberryman]

wording changes made in 212ef98