MSFS-Mega-Pack / MSFS2020-livery-manager

The official MSFS2020 Livery Megapack Manager. Choose which liveries to install, and keep them all updated.
https://discord.gg/g8ARRRQxyH
Other
123 stars 23 forks source link

adds check zip with html content raise error #509

Closed mommel closed 2 years ago

mommel commented 2 years ago

Closes #XX

Description

At present the download process will halt if the zip file is not found, because a html page is downloaded instead of running into an error, that leads the unzip process to fail. This change will react on exact that issue.

The new behavior would be: If the file size of the downloaded zip is below 20kb an error will be thrown, but the process of other working zip files will not be halted. Additionally the process gets logged and the title of the html page gets tried to be added to the error log.

Review focus

Try to download e.g. A320 Neo airfrance-skyteam-fhepi with current version and do the same with the changed version.

Checklist

A build will automatically be run by GitHub actions when any changes are made on this PR. This must complete successfully before merging.

Screenshots or videos

Not needed as there is no visible change

GewoonJaap commented 2 years ago

Thanks alot. I will take a look tomorrow and merge it